Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Export environments #46

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Update: Export environments #46

merged 1 commit into from
Aug 5, 2021

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Aug 4, 2021

This exports an environments object from the Legacy object based on #39 (comment).

@nzakas nzakas added enhancement New feature or request accepted labels Aug 4, 2021
@nzakas nzakas requested a review from mdjermanovic August 4, 2021 18:06
mdjermanovic
mdjermanovic approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I updated eslint/eslint#14865. and the checks are passing except for Browser Test but that seems unrelated to this change.

@mdjermanovic mdjermanovic merged commit 7e5e4e5 into main Aug 5, 2021
@mdjermanovic mdjermanovic deleted the environments branch August 5, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nzakas @mdjermanovic